-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mono delay #843
Fix mono delay #843
Conversation
That doesn't fix the problem.
To fulfill the requirement, both is actually needed. With our fix, but without
|
Delays for blocking eh is still broken.
|
Add more tests, please. Those cases which this PR fixes. |
I can add some to Would that be good enough then? |
Yes, please. |
@korken89 still working on more tests. Need to rewrite the test to do a sub-tick test |
Alright! |
@burrbull I wasn't able to add tests to the blocking functions; those are hard to test reliably. But I now test all EDIT: I added some tests for the blocking functions and they do work, but they are unreliable. So I disabled them by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort!
Fixes #844.
Solution
.micros()
with.micros_at_least()
and all.millis()
with.millis_at_least()
.Open questions / Problems
rtic-time
, and indirectly therefore also forrtic-monotonics
andrtic
itself. This would require all of those to be updated to a new major version.embedded-hal
's definitions ofDelayX
. So should we yank those?