-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Workbench 2024.09.0, including umask changes from dev #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent group access
Update umask from 0027 to 0077 per security recommendation
ianpittwood
requested review from
cm421,
melissa-barca,
colearendt,
bschwedler and
costrouc
as code owners
September 24, 2024 12:53
* Remove maybe_install_vs_code as the versions that depend on this are no longer supported. * Update default VS Code URL to PWB Code Server. * Remove `--verbose` arg that isn't supported by PWB Code Server
Bump Workbench to v2024.09.0
Update R & Python for Workbench
bschwedler
changed the title
Merge Workbench umask change from dev to main
Release Workbench 2024.09.0, including umask changes from dev
Sep 24, 2024
bschwedler
requested review from
GCRev,
zachhannum and
melissa-barca
and removed request for
melissa-barca
September 24, 2024 17:30
zachhannum
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Additional debug logging can be enabled through logging.conf if required
Stop writing launcher debug logs to container
GCRev
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.