Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ordered = TRUE for colorFactor fixes #800 #801

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bogaotory
Copy link

When the code is written as pal <- colorFactor(c("navy", "red"), domain = c("ship", "pirate")), then it is highly likely that the user's intention is to have navy for ship, and red for pirate.
Therefore it makes more sense that colorFactor should assume that the domain vector is already ordered (ordered = TRUE) unless stated otherwise.

PR task list:

When the code is written as `pal <- colorFactor(c("navy", "red"), domain = c("ship", "pirate"))`, then it is highly likely that the user's intention is to have `navy` for `ship`, and `red` for `pirate`.
Therefore it makes more sense that `colorFactor` should assume that the `domain` vector is already ordered (`ordered = TRUE`) unless stated otherwise.
@CLAassistant
Copy link

CLAassistant commented May 11, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants