Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand repo links #1447

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

expand repo links #1447

wants to merge 5 commits into from

Conversation

ElenaMetori
Copy link

No description provided.

Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool ! Thanks.

Maybe we could some test like with

test_that("bs4_book() repo specification works - GitLab", {
skip_if_bs4_book_deps_missing()
book <- local_bs4_book(
output_options = list(
repo = "https://gitlab.com/hadley/ggplot2-book"
)
)
html <- xml2::read_html(file.path(book, "_book", "index.html"))
expect_equal(
xml2::xml_attr(xml2::xml_child(xml2::xml_find_first(html, "//a[@id='book-repo']")), "class"),
"fab fa-gitlab"
)
})

DESCRIPTION Outdated
@@ -78,6 +78,7 @@ Suggests:
rsconnect (>= 0.4.3),
servr (>= 0.13),
shiny,
svglite,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why svglite is added ?

Missing suggest ? I don't see where it is used in the PR.

Copy link
Author

@ElenaMetori ElenaMetori Nov 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to pass the check, since it's used in inst/examples/index.Rmd, otherwise it doesn't let me make a PR... the "build and deploy book" one

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So missing suggest - thanks !

As this is for rendering this book only (bookdown demo works ok), I looked into it closer. I believe this is due to change in knitr where svglite is called (yihui/knitr@4300e49)

And we are indeed asking for svglite in our gitbook format for this book

bookdown::gitbook:
dev: svglite

So this is really a dependency only for the book. We do plan its installation

lapply(c('DT', 'formatR', 'svglite', 'rticles'), function(pkg) {
if (system.file(package = pkg) == '') install.packages(pkg)
})

but too late compare to knitr option resolution.

So we do need to add it only for our documentation book and not the whole package in there

Config/Needs/book: remotes, webshot

This is what is used for additional deps when building the book

- uses: r-lib/actions/setup-r-dependencies@v2
with:
extra-packages: local::.
needs: book

So can you move it ?

Thanks

@CLAassistant
Copy link

CLAassistant commented Apr 17, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants