This repository has been archived by the owner on Sep 22, 2022. It is now read-only.
add last failed tx processing #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
so the issue was about to resend any failed tx by querying a tx hash
|
|
added page /#/checktx |
rstormsf
reviewed
Apr 16, 2018
src/stores/txStore.js
Outdated
| } | ||
|
|
||
| async _multisend({slice, addPerTx}) { | ||
| alert('ffff') |
rstormsf
reviewed
Apr 16, 2018
src/components/checkTx.js
Outdated
| onSubmit(e){ | ||
| e.preventDefault() | ||
|
|
||
| this.tokenStore.setDecimals(0) |
rstormsf
reviewed
Apr 16, 2018
src/components/checkTx.js
Outdated
| import { inject, observer } from "mobx-react"; | ||
| import swal from 'sweetalert'; | ||
| import generateElement from '../generateElement' | ||
| import Example from './example.json' |
There was a problem hiding this comment.
do you need all of those dependencies?
rstormsf
reviewed
Apr 16, 2018
src/stores/txStore.js
Outdated
| const defaultAccount = this.web3Store.defaultAccount; | ||
| const web3 = this.web3Store.web3; | ||
| const status = await window.fetch(`https://${trustApiName}.etherscan.io/api?module=transaction&action=getstatus&txhash=${txHash}`) | ||
| .then((res) => { |
There was a problem hiding this comment.
please don't use Promises.
Use await
|
I have done fixes for cleaning ( I forget to commit deleting of debug alerts and other fixes before last PR). I reviewed other classes, and I think that tokenStore and gasPriceStore should be refactored, because many methods violates The Single Responsibility Principle and it was hard to me make additional features and fixes. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fix checks last failed tx when user enters token address