Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the_commander to KP server plugins #41
base: master
Are you sure you want to change the base?
Added the_commander to KP server plugins #41
Changes from 1 commit
1b1ccbc
41fe32d
c4f0a00
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of escaping, it might be better to use the
shlex.quote
function to escape the username, password, and mfa-token values. I think the downside to this approach would be that it'd break options--like=this
where the value is not exactly one token. It would be wroth testing that though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially I was using
shlex.quote
but it ended up not working out well. Just runningshlex.quote
on the user input led to stack traces in instances where the users password contained a single or double quote.Reproduce
re.escape
withshlex.quote
ValueError: No closing quotation
exception fromshlex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unable to reproduce this. StackOverflow might be a questionable source but per this answer it looks like it's the correct way to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not quite what's taking place in the code.
It's all dependent on what the user enters as a command. You can follow the same steps above without double quotes in
command
and be all set.