Addition of Transient Storage Opcodes #2778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests are still failing, I am investigating to find the root cause
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
… Arrays.copyOfRange; add more tests
….java Co-authored-by: Nazaret García Revetria <[email protected]>
fmacleal
force-pushed
the
fmacleal/addition_transient_storage_opcodes
branch
from
d6dc804 to
8892bf3
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
* Adding the structure for transient storage opcodes - Finishing test validation for basic scenarios of TLOAD/TSTORE * Refactor from code to get advantage from the MutableRepository - In order to get advantage from the whole flow of tracking, rollback and commits already present in the MutableRepository. We refactored a bit the logic of transient storage, now it's simpler. * Adding more tests defined on the EIP-1153 spec * Adding tests for the different create contexts EIP1153 * Addressing comments from review * Adding more scenarios of test with dynamic execution context
fmacleal
force-pushed
the
fmacleal/addition_transient_storage_opcodes
branch
from
f244dc2 to
551df42
Compare
fmacleal
force-pushed
the
fmacleal/addition_transient_storage_opcodes
branch
from
612a66a to
99599fb
Compare
* Added tests for dynamic execution contexts - WIP - Now we will add unit tests for underflow execution tests * Added tests for dynamic execution contexts - We had to add unit tests for underflow execution tests since isn't possible write contract for these scenarios - Now we have all the tests regarding execution context with different types of calls, missing the gas cost calculation that will be done in a later task * Addressing review comments
| //given | ||
| ActivationConfig.ForBlock activations = mock(ActivationConfig.ForBlock.class); | ||
| when(activations.isActive(RSKIP446)).thenReturn(true); | ||
| String expected = "0000000000000000000000000000000000000000000000000000000000000000"; |
Check notice
Code scanning / CodeQL
Unread local variable Note test
- Added scenarios for dynamic executions with revert and invalid
- All the tests from the EIP for reentrancy contexts are covered now
- Added basic scenario of gas measure costs for Transient Storage - Stil needed to add more scenarios of tests for run out of gas
- Added basic scenario of gas measure costs for Transient Storage - Added scenarios of run out of gas exception loops - Still missing some tests with gas consumption for some execution contexts
…ition Transient Storage gas cost calculation
Vovchyk
reviewed
Dec 11, 2024
Co-authored-by: Vovchyk <[email protected]>
- As specified in the EIP-1153, it was added test scenarios for reentrancy after selfdestruct. - Besides that, we refactored the folder that contained the DSL tests files
|
The transient storage resets between blocks, but not between transactions. It'd be good to add a test with multiple transactions on the same block on the test dsl tests. |
…-test-cases Added test scenarios for selfdestruct cases
fmacleal
force-pushed
the
fmacleal/addition_transient_storage_opcodes
branch
from
d0ccf35 to
2090bea
Compare
- After have added a scenario of DSL test where two we check storage between transactions inside same block, we noticed a bug. This commit fixes it clearing the transient storage after the tx finishes.
Fixing conflicts of the master as well.
|
This looks good now |
- In order to have a better validation of real use of TLOAD/TSTORE, we changed some DSL tests to not create a new block after every tx. This way, we validate that the transient storage it's correctly managed across the different tx. - Small refactor was added in the MutableTrie creation with a better name stating that we are creating an in memory trie.
|
Vovchyk
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to implements the RSKIP-446 that handles the transient storage opcodes defined int he RSKIP-446, which aims to be compatible with EIP-1153 from Ethereum.
The PR still in draft mode because some tests need to be fixed and added.
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: