Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC implementing a simple Dependency Injection system for RSKj.
Description
POC implementing a simple Dependency Injection system for RSKj. This system is not invasive, meaning that it can be applied for the dependencies we consider relevant while leaving others aside (no changes). For showcasing purposes,
co.rsk.net.handler.quota.TxQuotaChecker
is being injected inco.rsk.core.bc.TransactionPoolImpl#TransactionPoolImpl
using this new mechanism.The feature is yet a draft, subject to changes or bugs. It needs thorougher testing before considering it production ready, although it seems not very invasive or potentially problematic.
Motivation and Context
Injecting dependencies via constructor is sometimes tedious and affects multiple nested classes. This PR aims to simplify this.
How Has This Been Tested?
Types of changes
Checklist: