Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json RPC method parameter validation #2097

Merged
merged 59 commits into from
Oct 12, 2023
Merged

Json RPC method parameter validation #2097

merged 59 commits into from
Oct 12, 2023

Commits on Aug 9, 2023

  1. Updating BlockHash related methods having validated parameters. Added… 

    … blockHash, Tx Hash and Hex Index parameters and deserializers
    @asoto-iov
    asoto-iov committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    af96058 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Updated deserializers parent class and updated new eth_getTransaction… 

    ….. related methods having parameter validation
    @asoto-iov
    asoto-iov committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    22cc178 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. fix hex input validation

    @casiojapi
    casiojapi committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    f1baf19 View commit details
    Browse the repository at this point in the history

  2. fix unit test exception message

    @casiojapi
    casiojapi committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    d45a14f View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. fix sonarqube warning

    @casiojapi
    casiojapi committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    1722017 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. add serialVersionUID to deserializer

    @casiojapi
    casiojapi committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    50df9f9 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2023

  1. Add deserializers for CallArguments, RawData, Address and BlockIdenti… 

    …fier
    @rmoreliovlabs
    rmoreliovlabs committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    bc6baa5 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Fix sonarcloud issues

    @rmoreliovlabs
    rmoreliovlabs committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    ba11d0f View commit details
    Browse the repository at this point in the history

  2. Refactor deserializers

    @rmoreliovlabs
    rmoreliovlabs committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    e9f27a0 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Add BlockRef and BlockRefParam classes

    @rmoreliovlabs
    rmoreliovlabs committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    9e04a89 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Refactor BlockRefParam

    @rmoreliovlabs
    rmoreliovlabs committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    63e7dd6 View commit details
    Browse the repository at this point in the history

  2. Adding new Parameter classes

    @asoto-iov
    asoto-iov committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    85c2fe0 View commit details
    Browse the repository at this point in the history

  3. Refactor BlockRefParam deserialize to check for the param's type

    @rmoreliovlabs
    rmoreliovlabs committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    acbde9e View commit details
    Browse the repository at this point in the history

  4. Updating eth_newFilter method with FilterRequestParam

    @asoto-iov
    asoto-iov committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    8c5affe View commit details
    Browse the repository at this point in the history

  5. Updating eth_getLogs method with FilterRequestParam

    @asoto-iov
    asoto-iov committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    27cc17d View commit details
    Browse the repository at this point in the history

  6. Adding param validation to eth_unistallFilter, eth_getFilterChanges a… 

    …nd eth_getFilterLogs. Fixing failing test from previous commit
    @asoto-iov
    asoto-iov committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    7a9a5d4 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. Merge pull request #2117 from rsksmart/json_rpc_param_validation_pt1 

    Adding new FilterResquest Parameter class for JsonPRC
    @Vovchyk
    Vovchyk authored Sep 4, 2023
    Configuration menu
    Copy the full SHA
    95d61d6 View commit details
    Browse the repository at this point in the history

  2. Refactor CallArgumentsParam and add HexNumberParam

    @rmoreliovlabs
    rmoreliovlabs committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    eda346b View commit details
    Browse the repository at this point in the history

  3. Fix SonarCloud issues

    @rmoreliovlabs
    rmoreliovlabs committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    5c00e1e View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Code cleaning

    @rmoreliovlabs
    rmoreliovlabs committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    a0f9f5a View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Add HexKeyParam and HexDurationParam classes

    @rmoreliovlabs
    rmoreliovlabs committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    7bfa8ee View commit details
    Browse the repository at this point in the history

  2. Fix sonar issues

    @rmoreliovlabs
    rmoreliovlabs committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    e970d38 View commit details
    Browse the repository at this point in the history

  3. Remove Serializable implementation from HexStringParam child classes

    @rmoreliovlabs
    rmoreliovlabs committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    207d69a View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Merge branch 'master' into json_rpc_param_validation

    @Vovchyk
    Vovchyk authored Sep 8, 2023
    Configuration menu
    Copy the full SHA
    8cc47ef View commit details
    Browse the repository at this point in the history

  2. Fix failing tests

    @rmoreliovlabs
    rmoreliovlabs committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    9104c17 View commit details
    Browse the repository at this point in the history

  3. Implement deserializers

    @rmoreliovlabs
    rmoreliovlabs committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    e6f9cc7 View commit details
    Browse the repository at this point in the history

  4. Refactor CallArgumentsParam implementation

    @rmoreliovlabs
    rmoreliovlabs committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    5963770 View commit details
    Browse the repository at this point in the history

  5. Make sendTransaction method synchronized

    @rmoreliovlabs
    rmoreliovlabs committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    d1f32b5 View commit details
    Browse the repository at this point in the history

  6. Fix code smells

    @rmoreliovlabs
    rmoreliovlabs committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    fddec39 View commit details
    Browse the repository at this point in the history

  7. Suppress Sonar warnings

    @rmoreliovlabs
    rmoreliovlabs committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    d0fe948 View commit details
    Browse the repository at this point in the history

  8. Fix failing tests on EthModuleTest

    @rmoreliovlabs
    rmoreliovlabs committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    b3ed700 View commit details
    Browse the repository at this point in the history

  9. Merge pull request #2121 from rsksmart/implement_json_param_validation 

    Implement json param validation
    @Vovchyk
    Vovchyk authored Sep 8, 2023
    Configuration menu
    Copy the full SHA
    f36a9fc View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Update methods argument classes

    @rmoreliovlabs
    rmoreliovlabs committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    5131f49 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Merge pull request #2130 from rsksmart/json_rpc_param_validation_pt3 

    Update methods argument classes
    @Vovchyk
    Vovchyk authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    4ad802d View commit details
    Browse the repository at this point in the history

  2. Remove unused methods

    @rmoreliovlabs
    rmoreliovlabs committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    aefe3d7 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Update methods arguments types

    @rmoreliovlabs
    rmoreliovlabs committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    c717e62 View commit details
    Browse the repository at this point in the history

  2. Fix failing tests

    @rmoreliovlabs
    rmoreliovlabs committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    66589f9 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Merge pull request #2132 from rsksmart/json_rpc_param_validation_pt5 

    Update methods arguments types
    @Vovchyk
    Vovchyk authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    35df451 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into json_rpc_param_vali… 

    …dation
    @Vovchyk
    Vovchyk committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    59ebddf View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Addressing comments

    @rmoreliovlabs
    rmoreliovlabs committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    50412d2 View commit details
    Browse the repository at this point in the history

  2. Fix failing tests

    @rmoreliovlabs
    rmoreliovlabs committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    d770ff7 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Move null check from HexKeyParam to the importRawKey method

    @rmoreliovlabs
    rmoreliovlabs committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    016b547 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Check null value in newAccount method

    @asoto-iov
    asoto-iov committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    bdc6dd1 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2136 from rsksmart/check_null_parameter_for_new_a… 

    …ccount_method

Check null value in newAccount method
    @Vovchyk
    Vovchyk authored Sep 20, 2023
    Configuration menu
    Copy the full SHA
    82079f9 View commit details
    Browse the repository at this point in the history

  3. Revert changes on EthModuleWallet sign method

    @rmoreliovlabs
    rmoreliovlabs committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    aabccdd View commit details
    Browse the repository at this point in the history

  4. Remove unused imports

    @rmoreliovlabs
    rmoreliovlabs committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    61c0687 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Add (C) header to new files

    @rmoreliovlabs
    rmoreliovlabs committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    0dd8a3e View commit details
    Browse the repository at this point in the history

  2. Update invalid hex error messages

    @rmoreliovlabs
    rmoreliovlabs committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    5ca790a View commit details
    Browse the repository at this point in the history

  3. Send error object to invalidParamError for logging

    @rmoreliovlabs
    rmoreliovlabs committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    8d27c79 View commit details
    Browse the repository at this point in the history

  4. Adding support for null topics

    @asoto-iov
    asoto-iov committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    24fe940 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. minor code improvement

    @asoto-iov
    asoto-iov committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    73909be View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2139 from rsksmart/support_null_topics_in_FilterR… 

    …equest_parameter

Adding support for null topics
    @Vovchyk
    Vovchyk authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    f05a209 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into json_rpc_param_vali… 

    …dation
    @Vovchyk
    Vovchyk committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    66549ed View commit details
    Browse the repository at this point in the history

  4. Fixed tests after the merge from master

    @Vovchyk
    Vovchyk committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    55b42e8 View commit details
    Browse the repository at this point in the history

  5. Added proper handling of number parsing

    @Vovchyk
    Vovchyk committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    3b3bcc6 View commit details
    Browse the repository at this point in the history

  6. Added check for empty string in HexIndexParamTest

    @Vovchyk
    Vovchyk committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    5d0a327 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #2140 from rsksmart/hex-num-parsing 

    Added proper handling of number parsing
    @Vovchyk
    Vovchyk authored Sep 22, 2023
    Configuration menu
    Copy the full SHA
    4e64426 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Merge branch 'master' into json_rpc_param_validation

    @Vovchyk
    Vovchyk authored Oct 3, 2023
    Configuration menu
    Copy the full SHA
    59173f6 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Merge branch 'master' into json_rpc_param_validation

    @Vovchyk
    Vovchyk authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    bdc22a1 View commit details
    Browse the repository at this point in the history