Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json rpc benchmarking framework #2023

Merged
merged 49 commits into from
Jul 31, 2023
Merged

Json rpc benchmarking framework #2023

merged 49 commits into from
Jul 31, 2023

Conversation

illuque-iov
Copy link

Introducing Benchmarking framework using JMH

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

@illuque-iov illuque-iov force-pushed the json_rpc_benchmarking_framework branch 2 times, most recently from a711ca9 to 0e69bf7 Compare May 16, 2023 07:58
fedejinich
fedejinich reviewed May 30, 2023
View reviewed changes
rskj-core/src/jmh/java/co/rsk/jmh/web3/Web3Connector.java
import java.util.List;
import java.util.Map;

public interface Web3Connector {
Copy link
Contributor

@fedejinich fedejinich May 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about reusing the already existing Web3 interfaces for this. Something extracted from here

public interface Web3 extends InternalService, Web3TxPoolModule, Web3EthModule, Web3EvmModule, Web3MnrModule, Web3DebugModule, Web3TraceModule, Web3RskModule {

Maybe not all of them, but I guess you can prevent writing the same interface twice (i.e. Web3EthModule)

great work btw!

@illuque-iov illuque-iov force-pushed the json_rpc_benchmarking_framework branch 4 times, most recently from 275e310 to 0899d64 Compare June 23, 2023 10:45
@illuque-iov illuque-iov force-pushed the json_rpc_benchmarking_framework branch from dba1b50 to 2e90779 Compare July 4, 2023 15:28
@illuque-iov illuque-iov marked this pull request as ready for review July 4, 2023 15:28
@illuque-iov illuque-iov requested a review from Vovchyk July 4, 2023 15:29
Iago Lluque and others added 19 commits July 27, 2023 09:47
Adding rpc benchmarking skeleton
1dd09d2
Removing jmh Gradle plugin and use vanilla one instead
36a8392
Implemented Gradle task handling OOTB jmh parameters and/or custom su…
c57d469 
…bset
Simplified Benchmark set up and running
b74b56b
Added README.md
478c33c
Fixed verification-metadata.xml
755757b
Removed not needed jmh Gradle task
c37238f
Naive and preliminar implementation of ethSendRawTransaction to showc…
fc068e0 
…ase how to add new methods to the benchmark suite
Do not include JMH jar on distribution
cd3aaf6
Implemented sendTransaction and sendRawTransaction benchmarking methods
1e34ece 
Applied also some generic simplifications
@rmoreliovlabs
Added eth_getLogs related methods to the benchmark
41eb83e
Removed network specific config files but for regtest (we have decide…
2ae13e7 
…d to use fixed snapshots as benchmark references) and reduced default iteration numbers
Added example for custom methods not included in Web3J
f610726
Increased block wait time for sendTransaction benchmarking to always …
853313a 
…work
Implemented debug methods benchmark
3695480
Adaptations to benchmark on testnet data
2c57fc1
Refactored and simplified Benchmark runners, plans and config
52a90d9
Addressed PR comments on Benchmarking module
5f0a798
Adaptations to benchmark on testnet data
28a6642
asoto-iov and others added 21 commits July 27, 2023 09:47
@asoto-iov
Adding extra rpc calls to benchmark
c857b19
@asoto-iov
removing custom timeouts
e14ede5
@asoto-iov
updating config
47bbb87
@asoto-iov
adding empty parameters methods
f1937e4
@asoto-iov
Removing unnecesary timeouts from benchmark
ed41396
@asoto-iov
adding new config data
e5ad6ee
@asoto-iov
Updating regtest config usage
f426721
@asoto-iov
Moving ethSign benchmarking to Local Runner
7ad43c0
@asoto-iov
Renaming LocalBase class
a3f32a7
@rmoreliovlabs
Fix eth call config
efbdd26
@rmoreliovlabs
Refact EthPlan class name
c30629e
@rmoreliovlabs
Refactored EthCall plan to not create transactions
4c4c5ab
@rmoreliovlabs
Moved eth call benchmark to BenchmarkLocalWalletWeb3
99ada8c
@rmoreliovlabs
Updated eth call with tRIF transactions
a102471
@rmoreliovlabs
Using data old enough with block number before 3_600_000
4e608fa
@rmoreliovlabs
Using necessary values for eth_call
7bffb7b
@rmoreliovlabs
Removing other unnecessary props for eth_call
f95ba13
@rmoreliovlabs
Small refactor and renamings
59440bb
Try improving benchmarking stability by increasing warmups and removi…
174662f 
…ng forks
Reduced logic under benchmark methods
20fb503
Improved eth_getLogs benchmarking
dc58685
@illuque-iov illuque-iov force-pushed the json_rpc_benchmarking_framework branch from 2e90779 to dc58685 Compare July 27, 2023 07:48
@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Vovchyk
Copy link
Contributor

Vovchyk commented Jul 27, 2023

pipeline:run

2 similar comments
@Vovchyk
Copy link
Contributor

Vovchyk commented Jul 27, 2023

pipeline:run

@Vovchyk
Copy link
Contributor

Vovchyk commented Jul 27, 2023

pipeline:run

@Vovchyk Vovchyk merged commit 46cce57 into master Jul 31, 2023
4 of 5 checks passed
@Vovchyk Vovchyk deleted the json_rpc_benchmarking_framework branch July 31, 2023 10:20
@aeidelman aeidelman added this to the Fingerroot 5.1.0 milestone Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedejinich fedejinich fedejinich left review comments

@Vovchyk Vovchyk Vovchyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Fingerroot 5.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@illuque-iov @Vovchyk @fedejinich @aeidelman @rmoreliovlabs @asoto-iov