Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DI POC #1899

Closed
wants to merge 1 commit into from
Closed

DI POC #1899

wants to merge 1 commit into from

Conversation

illuque-iov
Copy link

WIP POC in order to have dependency injection on RSK

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

71.2% 71.2% Coverage
0.0% 0.0% Duplication

@illuque-iov illuque-iov changed the title WIP POC DIP POC Aug 22, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 22, 2023
View reviewed changes
rskj-core/src/test/java/co/rsk/vm/ExtCodeHashDslTest.java
@@ -41,6 +42,11 @@
*/
class ExtCodeHashDslTest {

@BeforeEach
public void setUp() {

Check notice

Code scanning / CodeQL

Confusing method names because of capitalization Note test

The method 'setUp' may be confused with
setup
Loading
.
@illuque-iov illuque-iov changed the title DIP POC DI POC Aug 22, 2023
@illuque-iov illuque-iov deleted the dip-poc branch August 22, 2023 11:35
@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

71.7% 71.7% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.16) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@illuque-iov