change to void on isValid HexValueValidator

rsksmart · Jul 27, 2023 · aa6e1bd · aa6e1bd
1 parent 8a6f9fb
commit aa6e1bd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/rskj-core/src/main/java/org/ethereum/rpc/validation/HexValueValidator.java b/rskj-core/src/main/java/org/ethereum/rpc/validation/HexValueValidator.java
@@ -24,10 +24,9 @@
 public final class HexValueValidator {
     private HexValueValidator(){}
 
-    public static boolean isValid(String input){
+    public static void isValid(String input){
         if (!HexUtils.isHexWithPrefix(input)) {
             throw RskJsonRpcRequestException.invalidParamError("Invalid argument: " + input + ": param should be a hex value string.");
         }
-        return true;
     }
 }
diff --git a/rskj-core/src/test/java/org/ethereum/rpc/validation/HexValueValidatorTest.java b/rskj-core/src/test/java/org/ethereum/rpc/validation/HexValueValidatorTest.java
@@ -27,12 +27,12 @@ class HexValueValidatorTest {
 
     @Test
     void testValidHexadecimals() {
-        assertTrue(HexValueValidator.isValid("0x0"));
-        assertTrue(HexValueValidator.isValid("0x123"));
-        assertTrue(HexValueValidator.isValid("0xabcdef"));
-        assertTrue(HexValueValidator.isValid("0x0000000000000000000000000000000001000008"));
-        assertTrue(HexValueValidator.isValid("0xABCDEF")); // Uppercase are not allowed in Ethereum
-        assertTrue(HexValueValidator.isValid("0x0123456789")); //Numbers staring by 0x0 is not allowed in Ethereum
+        assertDoesNotThrow(() -> HexValueValidator.isValid("0x0"));
+        assertDoesNotThrow(() -> HexValueValidator.isValid("0x123"));
+        assertDoesNotThrow(() -> HexValueValidator.isValid("0xabcdef"));
+        assertDoesNotThrow(() -> HexValueValidator.isValid("0x0000000000000000000000000000000001000008"));
+        assertDoesNotThrow(() -> HexValueValidator.isValid("0xABCDEF")); // Uppercase are not allowed in Ethereum
+        assertDoesNotThrow(() -> HexValueValidator.isValid("0x0123456789")); //Numbers staring by 0x0 is not allowed in Ethereum
     }
 
     @Test