feat: added a test to check a tx with negative block height is invalid

rsksmart · Dec 17, 2024 · 25c1834 · 25c1834
1 parent d7a0091
commit 25c1834
Showing 1 changed file with 19 additions and 5 deletions.
diff --git a/rskj-core/src/test/java/co/rsk/peg/RegisterBtcTransactionIT.java b/rskj-core/src/test/java/co/rsk/peg/RegisterBtcTransactionIT.java
@@ -112,7 +112,7 @@ void whenRegisterALegacyBtcTransaction_shouldRegisterTheNewUtxoAndTransferTheRbt
         co.rsk.core.Coin expectedReceiverBalance = receiverBalance.add(co.rsk.core.Coin.fromBitcoin(btcTransferred));
 
         // Act
-        registerBtcTransactionAndCommit();
+        registerBtcTransactionAndCommit(btcBlockWithPmtHeight);
 
         // Assert
         Optional<Long> heightIfBtcTxHashIsAlreadyProcessed = bridgeStorageProvider.getHeightIfBtcTxhashIsAlreadyProcessed(bitcoinTransaction.getHash());
@@ -128,21 +128,35 @@ void whenRegisterALegacyBtcTransaction_shouldRegisterTheNewUtxoAndTransferTheRbt
     @Test
     void whenRegisterARepeatedLegacyBtcTransaction_shouldNotPerformAnyChange() throws Exception {
         // Arrange
-        registerBtcTransactionAndCommit();
+        registerBtcTransactionAndCommit(btcBlockWithPmtHeight);
 
         co.rsk.core.Coin expectedReceiverBalance = track.getBalance(rskReceiver);
         List<UTXO> expectedFederationUTXOs = federationSupport.getActiveFederationBtcUTXOs();
 
         // Act
-        registerBtcTransactionAndCommit();
+        registerBtcTransactionAndCommit(btcBlockWithPmtHeight);
 
         // Assert
         assertEquals(expectedFederationUTXOs, federationSupport.getActiveFederationBtcUTXOs());
         assertEquals(expectedReceiverBalance, repository.getBalance(rskReceiver));
     }
 
-    private void registerBtcTransactionAndCommit() throws Exception {
-        bridgeSupport.registerBtcTransaction(rskTx, bitcoinTransaction.bitcoinSerialize(), btcBlockWithPmtHeight, pmtWithTransactions.bitcoinSerialize());
+    @Test
+    void whenRegisterALegacyBtcTransactionWithNegativeHeight_shouldNotPerformAnyChange() throws Exception {
+        // Arrange
+        co.rsk.core.Coin expectedReceiverBalance = track.getBalance(rskReceiver);
+        List<UTXO> expectedFederationUTXOs = federationSupport.getActiveFederationBtcUTXOs();
+
+        // Act
+        registerBtcTransactionAndCommit(-1);
+
+        // Assert
+        assertEquals(expectedFederationUTXOs, federationSupport.getActiveFederationBtcUTXOs());
+        assertEquals(expectedReceiverBalance, repository.getBalance(rskReceiver));
+    }
+
+    private void registerBtcTransactionAndCommit(int heightOfBlockWithPmt) throws Exception {
+        bridgeSupport.registerBtcTransaction(rskTx, bitcoinTransaction.bitcoinSerialize(), heightOfBlockWithPmt, pmtWithTransactions.bitcoinSerialize());
         bridgeSupport.save();
         track.commit();
     }