Added unit tests for secret_store module #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed unneeded include - Removed redundant check for blob_size
- Added unit tests for secret_store - Added mock implementations for the ocalls and seal API - Added trivial definitions of some open enclave types needed by the secret_store module
amendelzon
reviewed
Oct 8, 2024
- Mock functions are now prefixed with `mock_` to follow the general pattern used for other HAL tests - Mock implementation of functions needed by the tested unit are now part of the test suite, and just call the corresponding mock functions
- mocks no longer depend on specific definitions from secret_store - now asserting that the expected values are written to the kvstore - read/remove/exist tests now just write data interact directly to the kvstore and only test the read/remove/exist logic
|
@amendelzon Thanks for the suggestions. I pushed some commits addressing all of them, let me know if it looks good now. |
amendelzon
pushed a commit
that referenced
this pull request
Oct 22, 2024
- Added secret store unit tests - Minor changes to secret_store.c to allow for easier unit testing - Removed mock files from test coverage report
amendelzon
pushed a commit
that referenced
this pull request
Oct 22, 2024
- Added secret store unit tests - Minor changes to secret_store.c to allow for easier unit testing - Removed mock files from test coverage report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
secret_module.cto allow for full test coverage