Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SGX distribution scripts #201

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

amendelzon
Copy link
Collaborator

  • Moved dist to dist/ledger
  • Added dist/sgx with setup and run scripts
  • New SGX distribution building script (build-dist-sgx)
  • Added and updated distribution documentation for both Ledger and SGX
  • Additional HSM2DongleSGX unit tests for the onboarding operation

- Moved dist to dist/ledger
- Added dist/sgx with setup and run scripts
- New SGX distribution building script (build-dist-sgx)
- Added and updated distribution documentation for both Leger and SGX
- Additional HSM2DongleSGX unit tests for the onboarding operation
italo-sampaio
italo-sampaio previously approved these changes Sep 24, 2024
Copy link
Collaborator

@italo-sampaio italo-sampaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a few comments in the sgx Dockerfile

dist/sgx/Dockerfile Outdated Show resolved Hide resolved
dist/sgx/Dockerfile Outdated Show resolved Hide resolved
@amendelzon amendelzon merged commit 3004408 into feature/sgx-mvp Sep 25, 2024
4 checks passed
@amendelzon amendelzon deleted the feature/sgx-mvp--distscripts branch September 25, 2024 12:02
amendelzon added a commit that referenced this pull request Oct 22, 2024
- Moved dist to dist/ledger
- Added dist/sgx with setup and run scripts
- New SGX distribution building script (build-dist-sgx)
- Added and updated distribution documentation for both Leger and SGX
- Additional HSM2DongleSGX unit tests for the onboarding operation
amendelzon added a commit that referenced this pull request Oct 22, 2024
- Moved dist to dist/ledger
- Added dist/sgx with setup and run scripts
- New SGX distribution building script (build-dist-sgx)
- Added and updated distribution documentation for both Leger and SGX
- Additional HSM2DongleSGX unit tests for the onboarding operation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants