Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/payment-gas-estimation #263

Merged
merged 9 commits into from
Jul 18, 2024
Merged

fix/payment-gas-estimation #263

merged 9 commits into from
Jul 18, 2024

Conversation

franciscotobar
Copy link
Collaborator

@franciscotobar franciscotobar commented Jun 3, 2024 •
edited
Loading

What

  • New integration tests
  • Update rif-relay-client
  • Update rif-relay-server

Why

  • RSKj Arrowhead version have some changes in the gas cost
  • New smart wallet type

Refs

@franciscotobar franciscotobar changed the title test: integration tests fix/payment-gas -estimation Jun 6, 2024
@franciscotobar franciscotobar changed the title fix/payment-gas -estimation fix/payment-gas-estimation Jun 6, 2024
@franciscotobar franciscotobar marked this pull request as ready for review June 6, 2024 21:46
antomor
antomor approved these changes Jul 7, 2024
View reviewed changes
Copy link
Collaborator

@antomor antomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the nature of these changes, they're fine, but as we discussed, if we had to work on it in future, we may need to refactor these tests a bit.

package.json Outdated Show resolved Hide resolved
test/utils/NoClient.ts Show resolved Hide resolved
antomor
antomor approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@antomor antomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@franciscotobar LGTM, thank you 🙏🏼 !

@antomor antomor merged commit cd52801 into main Jul 18, 2024
1 check passed
@antomor antomor deleted the fix/payment-gas-estimation branch July 18, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antomor antomor antomor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franciscotobar @antomor