Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: project upgrade #259

Merged
merged 26 commits into from
Jan 5, 2024
Merged

feat: project upgrade #259

merged 26 commits into from
Jan 5, 2024

Conversation

antomor
Copy link
Collaborator

@antomor antomor commented Jan 3, 2024

What

  • Upgrade the project dependencies
  • Replace web3 with ethers.js
  • refactor project structure
  • adds useful scripts and removes useless ones
  • strengthens linting and formatting

Why

  • Dependencies were outdated
  • Reduce technical debt

antomor and others added 18 commits January 3, 2024 14:16
@antomor
PP-358: configure the project to use ethers (#231)
90c20ff 
* chore: update package version

* feat: replace truffle/web3 with hardhat

* chore: add clean script in package.json

* test: fix hardhat network

* fix: remove unnecessary peer dependency

* fix: use the contracts from the root folder instead of dist

* chore: rename prettierrc to prettierrc.json5 for consistency across all the project

* chore: update package-lock.json

* chore: update rif-relay-contracts dependency
@antomor
PP-661: replace circleci with gh actions (#236)
a1f4bb8 
* build: add the build step in the prepare script

* chore: replace circleci with github action

* chore: rename workflow and use local rsk files

* fix: use rskj version 4.1.1

* fix: apply format rules to yml files
@franciscotobar @antomor
PP-642/migrate-test-utils-server (#233)
b564712 
* refactor: remove smartWalletFactory

* refactor(TestUtils): error handling

* refactor: remove unnecessary files

* refactor(TestUtils): wallet per owner
@ironFe93 @antomor
PP-640/custom smart wallet (#234)
1b20241
@AndresQuijano @antomor
PP639: Migrate SmartWallet tests (#232)
3e98b0a 
* feat: migrate the RIFSmartWallet integration tests

* refactor: implement @MetaMask signatures

* fix: change the way we create smart wallets
use ethers provider instead of hardhat
rename files

---------

Co-authored-by: Antonio Morrone <[email protected]>
@AndresQuijano @antomor
PP638: Migrate verifiers tests (#240)
abc861b 
* feat: migrate DeployVerifier integration test.
@ironFe93 @antomor
PP-636/relay-hub-tests (#239)
c2ecd39 
* feat: refactor relayHub tests

---------

Co-authored-by: Christos Otarola <[email protected]>
Co-authored-by: Antonio Morrone <[email protected]>
@franciscotobar @antomor
PP-633/relay-server-tests (#238)
400db14 
* test(RelayServer): refactoring tests

* refactor(RelayServer): simplify relay transaction build

* refactor: buildServerUrl

* refactor: based on PR comments

* chore: dependency update

* refactor: rebase
@franciscotobar @antomor
PP-634/registration-manager-tests (#242)
aa81826 
* test: migrate the registration manager tests
@ironFe93 @antomor
PP-637: relay hub gas consumption tests (#243)
42f032d 
* feat: refactor of gas tests
* fix: reduce concatenated messages, log lines, deploy hub util
@antomor
PP-680: remove buildServerUrl usage (#244)
f9548b2 
* fix: remove the buildServerUrl usage
* fix: remove non-null assertion
@ironFe93 @antomor
PP-686: gas estimation task (#245)
448b035 
* feat: ported gas estimation tests to script
@ironFe93 @franciscotobar @antomor
PP-635/relay-client-tests (#246)
0c38bf8 
* test(RelayClient): migration of the existing integration tests
* refactor: use already defined deployContract function

---------

Co-authored-by: Francisco Tobar <[email protected]>
Co-authored-by: Antonio Morrone <[email protected]>
@AndresQuijano @antomor
PP719: Adapt estimation script to calculate the cost of a deployment (#…
ffbe6cc 
…247)


* feat: add gas estimation for deploy

* feat: add additional estimation with token payment

* refactor: refactor the script to make it more readable
---------

Co-authored-by: Antonio Morrone <[email protected]>
@franciscotobar @antomor
fix/verify_with_relay_hub (#250)
711afee 
* refactor(RelayClient): verify with relay hub

* build: dependency update
@antomor
ci: update the rskj node version and configuration (#252)
dc62eca
@antomor
PP-803/optimize server startup (#254)
f9cdbdc 
* test: fix failing tests
@antomor @franciscotobar
PP-842: fix underpriced transactions (#255)
2474a0c 
* test: fix broken tests

* test: include tests to cover relay server fixes

* chore: move expectation outside the test

* build: version / relay-server dependency

---------

Co-authored-by: Francisco Tobar <[email protected]>
@antomor
Copy link
Collaborator Author

antomor commented Jan 3, 2024

This PR depends on #258

@antomor antomor self-assigned this Jan 3, 2024
@antomor antomor marked this pull request as ready for review January 4, 2024 15:57
franciscotobar
franciscotobar reviewed Jan 4, 2024
View reviewed changes
Readme.md Outdated Show resolved Hide resolved
franciscotobar
franciscotobar reviewed Jan 4, 2024
View reviewed changes
Readme.md Outdated Show resolved Hide resolved
franciscotobar
franciscotobar reviewed Jan 4, 2024
View reviewed changes
Readme.md Outdated Show resolved Hide resolved
franciscotobar
franciscotobar reviewed Jan 4, 2024
View reviewed changes
Readme.md Outdated Show resolved Hide resolved
franciscotobar
franciscotobar approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@franciscotobar franciscotobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

antomor and others added 7 commits January 5, 2024 08:47
@antomor @franciscotobar
Update Readme.md
16f7abb 
Co-authored-by: franciscotobar <[email protected]>
@antomor @franciscotobar
Update Readme.md
dd41ca8 
Co-authored-by: franciscotobar <[email protected]>
@antomor @franciscotobar
Update Readme.md
6ac7f2d 
Co-authored-by: franciscotobar <[email protected]>
@antomor @franciscotobar
Update Readme.md
c094450 
Co-authored-by: franciscotobar <[email protected]>
@antomor @franciscotobar
Update scripts/GasEstimation.ts
8f94b31 
Co-authored-by: franciscotobar <[email protected]>
@antomor
style: apply format rule
56527db
@franciscotobar
docs: readme
8f65f6a
@antomor antomor merged commit fa4a93e into main Jan 5, 2024
1 check passed
@antomor antomor deleted the develop branch January 5, 2024 15:34
zdaodu-iov pushed a commit to zdaodu-iov/rif-relay that referenced this pull request Jan 5, 2024
@antomor @franciscotobar
@ironFe93 @AndresQuijano
feat: project upgrade (rsksmart#259)
ce5bee2 
* PP-358: configure the project to use ethers (rsksmart#231)

* chore: update package version

* feat: replace truffle/web3 with hardhat

* chore: add clean script in package.json

* test: fix hardhat network

* fix: remove unnecessary peer dependency

* fix: use the contracts from the root folder instead of dist

* chore: rename prettierrc to prettierrc.json5 for consistency across all the project

* chore: update package-lock.json

* chore: update rif-relay-contracts dependency

* PP-661: replace circleci with gh actions (rsksmart#236)

* build: add the build step in the prepare script

* chore: replace circleci with github action

* chore: rename workflow and use local rsk files

* fix: use rskj version 4.1.1

* fix: apply format rules to yml files

* PP-642/migrate-test-utils-server (rsksmart#233)

* refactor: remove smartWalletFactory

* refactor(TestUtils): error handling

* refactor: remove unnecessary files

* refactor(TestUtils): wallet per owner

* PP-640/custom smart wallet (rsksmart#234)

* PP639: Migrate SmartWallet tests (rsksmart#232)

* feat: migrate the RIFSmartWallet integration tests

* refactor: implement @MetaMask signatures

* fix: change the way we create smart wallets
use ethers provider instead of hardhat
rename files

---------

Co-authored-by: Antonio Morrone <[email protected]>

* PP638: Migrate verifiers tests (rsksmart#240)

* feat: migrate DeployVerifier integration test.

* PP-636/relay-hub-tests (rsksmart#239)

* feat: refactor relayHub tests

---------

Co-authored-by: Christos Otarola <[email protected]>
Co-authored-by: Antonio Morrone <[email protected]>

* PP-633/relay-server-tests (rsksmart#238)

* test(RelayServer): refactoring tests

* refactor(RelayServer): simplify relay transaction build

* refactor: buildServerUrl

* refactor: based on PR comments

* chore: dependency update

* refactor: rebase

* PP-634/registration-manager-tests (rsksmart#242)

* test: migrate the registration manager tests

* PP-637: relay hub gas consumption tests (rsksmart#243)

* feat: refactor of gas tests
* fix: reduce concatenated messages, log lines, deploy hub util

* PP-680: remove buildServerUrl usage (rsksmart#244)

* fix: remove the buildServerUrl usage
* fix: remove non-null assertion

* PP-686: gas estimation task (rsksmart#245)

* feat: ported gas estimation tests to script

* PP-635/relay-client-tests (rsksmart#246)

* test(RelayClient): migration of the existing integration tests
* refactor: use already defined deployContract function

---------

Co-authored-by: Francisco Tobar <[email protected]>
Co-authored-by: Antonio Morrone <[email protected]>

* PP719: Adapt estimation script to calculate the cost of a deployment (rsksmart#247)


* feat: add gas estimation for deploy

* feat: add additional estimation with token payment

* refactor: refactor the script to make it more readable
---------

Co-authored-by: Antonio Morrone <[email protected]>

* fix/verify_with_relay_hub (rsksmart#250)

* refactor(RelayClient): verify with relay hub

* build: dependency update

* ci: update the rskj node version and configuration (rsksmart#252)

* PP-803/optimize server startup (rsksmart#254)

* test: fix failing tests

* PP-842: fix underpriced transactions (rsksmart#255)

* test: fix broken tests

* test: include tests to cover relay server fixes

* chore: move expectation outside the test

* build: version / relay-server dependency

---------

Co-authored-by: Francisco Tobar <[email protected]>

* fix: remove unused tests (rsksmart#258)

* Update Readme.md

Co-authored-by: franciscotobar <[email protected]>

* Update Readme.md

Co-authored-by: franciscotobar <[email protected]>

* Update Readme.md

Co-authored-by: franciscotobar <[email protected]>

* Update Readme.md

Co-authored-by: franciscotobar <[email protected]>

* Update scripts/GasEstimation.ts

Co-authored-by: franciscotobar <[email protected]>

* style: apply format rule

* docs: readme

---------

Co-authored-by: franciscotobar <[email protected]>
Co-authored-by: Christos Otarola <[email protected]>
Co-authored-by: AndresQuijano <[email protected]>
Co-authored-by: Christos Otarola <[email protected]>
Co-authored-by: Francisco Tobar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscotobar franciscotobar franciscotobar approved these changes

Assignees

@antomor antomor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antomor @franciscotobar @ironFe93 @AndresQuijano