Merge pull request #1 from PowerShell/master

Pulling updates from upstream

DscResources/MSFT_xSmbShare/MSFT_xSmbShare.psm1

@@ -315,27 +315,29 @@ function Test-TargetResource
         $Ensure
     )
     $testResult = $false;
-    $share = Get-SmbShare -Name $Name -ErrorAction SilentlyContinue -ErrorVariable ev
-    if ($Ensure -eq "Present")
+    $share = Get-TargetResource -Name $Name -Path $Path -ErrorAction SilentlyContinue -ErrorVariable ev
+    if ($Ensure -ne "Absent")
     {
-        if ($share -eq $null)
+        if ($share.Ensure -eq "Absent")
         {
             $testResult = $false
         }
-        elseif ($share -ne $null -and $PSBoundParameters.Count -gt 3)
-        # This means some other parameter in addition to Name, Path, Ensure could have been specified
-        # Which means we need to modify something
-        {
-            $testResult = $false
-        }
-        else
+        elseif ($share.Ensure -eq "Present")
         {
-            $testResult = $true
+            $Params = 'Name', 'Path', 'Description', 'ChangeAccess', 'ConcurrentUserLimit', 'EncryptData', 'FolderEnumerationMode', 'FullAccess', 'NoAccess', 'ReadAccess', 'Ensure'
+            if ($PSBoundParameters.Keys.Where({$_ -in $Params}) | ForEach-Object {Compare-Object -ReferenceObject $PSBoundParameters.$_ -DifferenceObject $share.$_})
+            { 
+                $testResult = $false
+            }
+            else
+            {
+                $testResult = $true
+            }
         }
     }
     else
     {
-        if ($share -eq $null)
+        if ($share.Ensure -eq "Absent")
         {
             $testResult = $true
         }

README.md

@@ -34,6 +34,9 @@ Admin shares, default shares, IPC$ share are examples.
 
 ## Versions
 
+### 1.1.0.0
+* Fixed bug in xSmbShare resource which was causing Test-TargetResource to return false negatives when more than three parameters were specified.
+
 ### 1.0.0.0
 
 * Initial release with the following resources 

xSmbShare.psd1

@@ -1,6 +1,6 @@
 @{
 # Version number of this module.
-ModuleVersion = '1.0.1'
+ModuleVersion = '1.1.0.0'
 
 # ID used to uniquely identify this module
 GUID = '8831ca9a-3c47-4a5b-b401-29635dd24381'