Use rpmkeys --list in test cases #3434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updating the tests to rpmkeys is okay for sure, but we'll want to preserve the filesystem level tests. Without those, we don't actually know what the backend does or even what backend gets used, just that something works 😅 This already saved my a** at least once. |
This indeed does work with the fs backend nowadays. Since 42985d5 actually. Keep the find in the first case to make sure the key is in the right place. For the second test case the file is gone anyway.
|
There are a couple of other test having an even more thorough look on the file system. Keeping the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This indeed does work with the fs backend nowadays. Since 42985d5 actually.