Use consistent case in signature and key messages #3426
Conversation
The signature and key related messages are a historical mess of inconsistency, we have at least the following in closely related messages that happen under slightly different circumstances: - Header V4 RSA/SHA256 Signature - RSA signature: NOTFOUND - signatures OK - key ID - Key Fingerprint Just use lower case consistently for everything but acronyms, so the above becomes - Header V4 RSA/SHA256 signature - RSA signature: NOTFOUND - signatures OK - key ID - key fingerprint This will no doubt break somebody's fine-tuned script but we're breaking them in 6.0 anyhow so this is the right time for this kind of cleanup.
|
Loosely related to the multiple signatures stuff - this was driving me crazy when writing tests. |
|
(also, all the Signature/signature case differences while "digest" was consistently "digest") |
|
What about "Header"? |
|
Header (and Payload) only appear as the first word on the line where upper case seems appropriate. |
|
Oh and FWIW, there will be other changes to the messages coming through #3385. Those changes are best discussed in that ticket, I just think this is obvious enough not to require prior discussion. |
|
Not sure if I like that "only appear as the first word on the line" argument when we lower cased the first word everywhere else. Anyway, this is a lot better than before and we change change Payload and Header later on. |
|
Those other messages don't appear as the first thing on the line, they're just out of context here. But thanks for merging, will help preserve my sanity going forward 😅 |
The signature and key related messages are a historical mess of inconsistency, we have at least the following in closely related messages that happen under slightly different circumstances:
Just use lower case consistently for everything but acronyms, so the above becomes
This will no doubt break somebody's fine-tuned script but we're breaking them in 6.0 anyhow so this is the right time for this kind of cleanup.