Fix rpmsign --key-id regression #3423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmatilai
force-pushed
the
keyid
branch
2 times, most recently
from
3fff6d4
to
004c920
Compare
|
(gah, sure is Monday when you need so many fixups to messages etc for a patch this small) |
pmatilai
changed the title
|
All those edits and it was still wrong: just now realized the breakage wasn't limited to Sequoia, it occurred with Gpg too, so commit summary+message updated. |
Commit d99186f failed to update the popt alias to the new macro. So --key-id worked only if you hadn't set %_openpgp_sign_id in your rpm macro config - the prime case for wanting to use --key-id to override that choice. Doh. Just goes to show what you don't test, really is broken by definition...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit d99186f failed to update the popt alias to the new macro. So --key-id worked only if you hadn't set %_openpgp_sign_id in your rpm macro config - the prime case for wanting to use --key-id to override that choice. Doh. Just goes to show what you don't test, really is broken by definition...