Fix a horrible performance regression caused by missing & #3422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the busiest functions in rpm was getting passed a new copy of a big unordered_map on each call during fingerprinting because "somebody" forgot a & in commit 08a6a5e. This isn't even noticeable in the test-suite or daily "update a few dozen packages" operation but when attempting to install/update a few thousand packages dragged this little buglet to the light... Why oh why C++ do you behave in such an idiotic manner in the face of stupid mistakes. Raw pointers at least give you a compiler error.
|
And the prize for the most impactful one-liner of the month goes to... |
dmnks
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the busiest functions in rpm was getting passed a new copy of a big unordered_map on each call during fingerprinting because "somebody" forgot a & in commit 08a6a5e. This isn't even noticeable in the test-suite or daily "update a few dozen packages" operation but when attempting to install/update a few thousand packages dragged this little buglet to the light...
Why oh why C++ do you behave in such an idiotic manner in the face of stupid mistakes. Raw pointers at least give you a compiler error.