-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configs: Rawhide to accept GPG key from future Fedora Rawhide+1 #1342
configs: Rawhide to accept GPG key from future Fedora Rawhide+1 #1342
Conversation
d079a38
to
daf35e8
Compare
@@ -42,7 +42,7 @@ user_agent={{ user_agent }} | |||
|
|||
{%- macro rawhide_gpg_keys() -%} | |||
file:///usr/share/distribution-gpg-keys/fedora/RPM-GPG-KEY-fedora-$releasever-primary | |||
{%- for version in [releasever|int, releasever|int - 1] | |||
{%- for version in [releasever|int, releasever|int - 1, releasever|int + 1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! My only qualm is what happens if the key doesn't exist yet? We don't want any kind of warning or error in that case. Hmm, I think we get an error if they key doesn't exist:
cannot open file: (2) - No such file or directory [/usr/share/distribution-gpg-keys/fedora/RPM-GPG-KEY-fedora-46-primary]
I think this should be wrapped in a check whether the key actually exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I installed this fatal error into the branching script:
File /usr/share/distribution-gpg-keys/fedora/RPM-GPG-KEY-fedora-43-primary not found!
The new Fedora Rawhide (42) requires a GPG key for Fedora 43,
which must be generated by Fedora Infrastructure team and shipped in the
distribution-gpg-keys.rpm package. This either has not happened yet, the
package is outdated, or it is not even installed on this box.
daf35e8
to
3de8828
Compare
This time, F42 key was generated on 2024-02-12. |
I have to say that I am not happy for this PR. IMO this will bring a new issue when we submit new config earlier than before branching (missing key). |
"fedora-repos update with the new keys is available in updates-testing" is though something different, I think that we should have a new entry in the F41 schedule like
Somewhere in the Fedora 41 schedule. To have a guidance that assures everything works. |
If we can get a new step into the Fedora release schedule, then this problem
This is being tracked here #1328 - though :-/ it's going to be a big change in |
I tried this with DNF4 and DNF5 and it prints no error when the file does not exists and it is silently ignored. Not sure if this is generally good, but for our case it is good. |
We were not able to find or create Copr project
Unless the HTTP status code above is >= 500, please check your configuration for:
|
I manually rebased this and merged as 66ca1e4 |
Fixes: #1338