Add flag to either consider or ignore EVR for extras #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extras filter originally considered NEVRA, but was changed to ignore EVR and consider only NA: https://bugzilla.redhat.com/show_bug.cgi?id=1684517 Since both the original and new behavior are required for different use cases, add a flag to support either behavior.
|
(The test failures do not look related to any of my changes. Looks like some dependency issues?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "extras" filter originally considered NEVRA, but was changed to ignore EVR and consider only NA: https://bugzilla.redhat.com/show_bug.cgi?id=1684517
We occasionally use third party repos that have RPMs with names that overlap with RPMs in standard repos, but with non-overlapping version numbers (eg. to get newer versions of software than is available in the standard repos.) If one of these third party repos is retired, we want to make sure that we remove any RPMs that came from it (either by downgrading to the standard RPMs or by switching to a replacement third party repo).
For many years, we used
yum list extrasordnf list --extrasto detect and handle orphaned RPMs like these. However, we recently encountered one of these repo retirements and noticed thatdnf list --extraswas no longer working as expected (it was no longer reporting any RPMs with names that overlap RPMs in other repos).We would like to have some way to make
dnfreport these version-mismatch orphans. Since both the original and new behavior seem to have legitimate use cases, a flag to select the relevant behavior seems appropriate.My intent (after this PR is merged) is to add another option to
dnf(maybednf list --extra-vers?) to expose this flag to users.