[backport] automatic: Check availability of config file #2148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream commit: 13ecc39
RHEL issue: https://issues.redhat.com/browse/RHEL-49743
If a configuration file is explicitly specified on the command line, ensure that it exists and is readable. If the file is not found, notify the user immediately and terminate the process.
This resolves issues where users may run dnf-automatic with unrecognized positional arguments, such as
dnf-automatic install
.The most natural approach to handle a non-existing config file would be by catching the exception thrown by the
read()
method of thelibdnf.conf.ConfigParser
class. Unfortunately, the Python bindings override theread()
method at the SWIG level, causing it to suppress any potentially raised IOError.For details see this section of the commit
rpm-software-management/libdnf@8f1fedf
Resolves: https://issues.redhat.com/browse/RHEL-46030