Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update need_reboot for dnf-automatic #2143

Merged

Conversation

Klaas-
Copy link
Contributor

@Klaas- Klaas- commented Oct 15, 2024

Hi,
the need_reboot from dnf does no longer match dnf-automatic. We noticed it will not reboot on microcode_ctl updates. I also added kernel-core because it was missing.
It now matches
https://github.com/rpm-software-management/dnf-plugins-core/blob/master/plugins/needs_restarting.py#L42-L44

Greetings
Klaas

@pep8speaks
Copy link

pep8speaks commented Oct 15, 2024

Hello @Klaas-! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-10-15 10:07:33 UTC

@Klaas-
Copy link
Contributor Author

Klaas- commented Oct 15, 2024

Hmm I missed #2140 but it's only adding kernel-core :)

@Klaas-
Copy link
Contributor Author

Klaas- commented Oct 15, 2024

The ci failures seem unrelated to my change.

DNF CI / Ansible Tests
nothing provides libstdc++.so.6(CXXABI_1.3.15)(64bit) needed by libdnf-0.73.3-20241015100822.1.gcd51f574.fc40.x86_64 from @commandline

testing-farm:fedora-41-x86_64:dnf-tests :
Problem 1: installed package dnf5-5.2.6.2-20241015010352.32.gb977f592.fc41.x86_64 obsoletes yum < 5 provided by yum-4.21.1-1.fc41.noarch from fedora

testing-farm:fedora-rawhide-x86_64:dnf-tests:
installed package dnf5-5.2.6.2-20241015010352.32.gb977f592.fc42.x86_64 obsoletes microdnf < 4 provided by microdnf-3.10.0-6.fc41.x86_64 from rawhide

@ppisar ppisar self-assigned this Oct 15, 2024
The need_reboot from dnf-automatic did not match NEED_REBOOT from
needs-restarting.
@ppisar ppisar force-pushed the Klaas-fix_automatic_reboot_pkgs branch from 032c5b8 to 53ea2ac Compare October 15, 2024 15:57
@ppisar
Copy link
Contributor

ppisar commented Oct 15, 2024

Thanks for the patch. I corrected the your pull request after merging a patch from Woomymy. I will merge your pull request once tests finish. The failures you observed are really unrelated.

@ppisar ppisar merged commit 193e3f4 into rpm-software-management:master Oct 16, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants