automatic: Fix applying the color option #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `color` option value wasn't passed in `dnf-automatic` usage so far. In the standard `dnf` command, the `Term` object is created before parsing the entire configuration, including command-line parameters. The `Term` is reinitialized within `Cli.configure` if the `color` option value was changed. In `dnf-automatic`, where configuration is processed in a single place, we can directly pass the value from the configuration.
kontura
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
coloroption value wasn't passed indnf-automaticusage so far.In the standard
dnfcommand, theTermobject is created before parsing the entire configuration, including command-line parameters. TheTermis reinitialized withinCli.configureif thecoloroption value was changed. Indnf-automatic, where configuration is processed in a single place, we can directly pass the value from the configuration.This is a follow-up to the #2003.