Fix project name in generated launch.json #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ithinuel
approved these changes
Sep 19, 2024
jannic
reviewed
Sep 20, 2024
| @@ -0,0 +1,45 @@ | |||
| // The format of this file is specified in https://probe.rs/docs/tools/vscode/#start-a-debug-session-with-minimum-configuration | |||
There was a problem hiding this comment.
This URL gives me a 404.
BTW json doesn't allow for comments. Did you verify that it's fine for vscode?
EDIT: nvm. I just noticed that this is copied from an already existing file. We still should fix the URL, but that can be done separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.vscode/launch.jsonfile has a hard-coded path to theprogramBinary, which does not work if you create a project with a different name usingcargo generate rp-rs/rp2040-project-template.rp2040-project-template/.vscode/launch.json
Line 27 in 4cfa8a7
This PR replaces that file with a generated
.vscode/launch.jsonfile, with the correct path to theprogramBinary. The rest of the file is unchanged.