Skip to content

Commit

Permalink
97 type definition for divide seems incorrect (#101)
Browse files Browse the repository at this point in the history
* fixed divide type declaration
  • Loading branch information
royNiladri authored Aug 2, 2023
1 parent 1d2d912 commit 08d2a77
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion dist/esm/big-decimal.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ declare class bigDecimal {
static multiply(number1: any, number2: any): string;
multiply(number: bigDecimal): bigDecimal;
static divide(number1: any, number2: any, precision?: number): string;
divide(number: bigDecimal, precision: any): bigDecimal;
divide(number: bigDecimal, precision?: number): bigDecimal;
static modulus(number1: any, number2: any): string;
modulus(number: bigDecimal): bigDecimal;
static compareTo(number1: any, number2: any): 0 | 1 | -1;
Expand Down
2 changes: 1 addition & 1 deletion dist/esm/big-decimal.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/node/big-decimal.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ declare class bigDecimal {
static multiply(number1: any, number2: any): string;
multiply(number: bigDecimal): bigDecimal;
static divide(number1: any, number2: any, precision?: number): string;
divide(number: bigDecimal, precision: any): bigDecimal;
divide(number: bigDecimal, precision?: number): bigDecimal;
static modulus(number1: any, number2: any): string;
modulus(number: bigDecimal): bigDecimal;
static compareTo(number1: any, number2: any): 0 | 1 | -1;
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "js-big-decimal",
"version": "2.0.0",
"version": "2.0.1",
"description": "Work with large numbers on the client side. Round them off to any required precision.",
"main": "dist/node/js-big-decimal",
"types": "dist/node/big-decimal",
Expand Down
2 changes: 1 addition & 1 deletion src/big-decimal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ class bigDecimal {
return divide(number1, number2, precision);
}

divide(number: bigDecimal, precision) {
divide(number: bigDecimal, precision?: number) {
return new bigDecimal(divide(this.value, number.getValue(), precision));
}

Expand Down

0 comments on commit 08d2a77

Please sign in to comment.