WIP: Add custom ca-certificate import into docker-entrypoint #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fager As mentioned in #237 (comment), I would rather not extend our images with support for publicly untrusted certificates, because I consider those only a valid choice in specific corner cases, and a bad choice for most other cases. People that are in such a corner case, will (or should) be able to figure out how to make it work, and other people shouldn't be tempted to go into that corner. Besides the principal position I also don't like to add and maintain the considerable complexity to our images. Thus I would not like to merge this PR. Sorry if I was not clear enough previously! |
|
@pabzm, @thomascube |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull-Request for Issue #237.
This pull request extends the container images to include the ability to insert custom CA certificates by mounting a volume when starting the container.
The implementation is not yet complete: