fixed a bug in Arc to Curve convertor

rough-stuff · May 12, 2018 · 3eb4dde · 3eb4dde
1 parent 2850bd3
commit 3eb4dde
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/dist/rough.js b/dist/rough.js
@@ -510,8 +510,8 @@ class RoughArcConverter {
     var numerator = this._rx * this._rx * this._ry * this._ry - this._rx * this._rx * y1dash * y1dash - this._ry * this._ry * x1dash * x1dash;
     if (numerator < 0) {
       let s = Math.sqrt(1 - (numerator / (this._rx * this._rx * this._ry * this._ry)));
-      this._rx = s;
-      this._ry = s;
+      this._rx = this._rx * s;
+      this._ry = this._ry * s;
       root = 0;
     } else {
       root = (largeArcFlag == sweepFlag ? -1.0 : 1.0) *

diff --git a/dist/rough.min.js b/dist/rough.min.js
diff --git a/dist/rough.umd.js b/dist/rough.umd.js
@@ -513,8 +513,8 @@ class RoughArcConverter {
     var numerator = this._rx * this._rx * this._ry * this._ry - this._rx * this._rx * y1dash * y1dash - this._ry * this._ry * x1dash * x1dash;
     if (numerator < 0) {
       let s = Math.sqrt(1 - (numerator / (this._rx * this._rx * this._ry * this._ry)));
-      this._rx = s;
-      this._ry = s;
+      this._rx = this._rx * s;
+      this._ry = this._ry * s;
       root = 0;
     } else {
       root = (largeArcFlag == sweepFlag ? -1.0 : 1.0) *

diff --git a/dist/rough.umd.min.js b/dist/rough.umd.min.js
diff --git a/src/path.js b/src/path.js
@@ -304,8 +304,8 @@ export class RoughArcConverter {
     var numerator = this._rx * this._rx * this._ry * this._ry - this._rx * this._rx * y1dash * y1dash - this._ry * this._ry * x1dash * x1dash;
     if (numerator < 0) {
       let s = Math.sqrt(1 - (numerator / (this._rx * this._rx * this._ry * this._ry)));
-      this._rx = s;
-      this._ry = s;
+      this._rx = this._rx * s;
+      this._ry = this._ry * s;
       root = 0;
     } else {
       root = (largeArcFlag == sweepFlag ? -1.0 : 1.0) *