Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Octant Round 5 data #135

Merged
merged 2 commits into from
Oct 13, 2024
Merged

feat: Octant Round 5 data #135

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
730bbf9
feat: Octant Round 5 data
cleanerzkp Oct 13, 2024
a53c35a
refactor: adjust structure, time and link per comments
cleanerzkp Oct 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions messages/dashboard.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,16 @@
[
{
"message": "Enjoying rotki? Consider ",
"message_highlight": "supporting us in",
"action": {
"text": "Octant Epoch 5",
"url": "https://octant.app/home"
},
"period": {
"start": 1728835200,
"end": 1729987200
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also end same time, so 16:00 UTC:

Suggested change
"end": 1729987200
"end": 1730044800

}
},
{
"message": "Enjoying rotki? Consider ",
"message_highlight": "supporting us in",
Expand Down
8 changes: 4 additions & 4 deletions messages/welcome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@
{
"header": "Enjoying rotki?",
"icon": "https://raw.githubusercontent.com/rotki/data/develop/messages/icon.svg",
"text": "rotki is part of the GIV-a-Palooza QF Round at Giveth",
"text": "rotki is part of the Octant Epoch 5",
"action": {
"text": "Support us here",
"url": "https://giveth.io/project/rotki"
"url": "https://octant.app/home"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to delete an old one. Just add a new one. Timestamps alone should decide what shows.

},
"period": {
"start": 1725948000,
"end": 1727258340
"start": 1728835200,
"end": 1729987200
}
},
{
Expand Down
Loading