Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename retrieve_engine_queue_stats to retrieve_engine_queues #95

Merged

Conversation

mondrasovic
Copy link

The new name better conveys the essence that we're retrieving only a list of queues associated with the given engine.

Copy link
Collaborator

@asgeirrr asgeirrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the prefix of the commit to fix: to force a minor version release so you can start using it in other projects. Also, refactor: commits do not show up in the generated changelog.

rossum_api/elis_api_client.py Outdated Show resolved Hide resolved
The new name better conveys the essence that we're retrieving only a list of queues associated with the given engine. The docstring pointing to official documentation was also corrected.
@mondrasovic mondrasovic force-pushed the mo/rename-retrieve-engine-queues branch from f5425ad to 7583358 Compare January 23, 2025 09:27
@asgeirrr asgeirrr merged commit 9247407 into rossumai:main Jan 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants