Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elis_api_client: Add support for retrieving EngineFields (sync + async) #91

Merged
merged 1 commit into from
Jan 14, 2025
Merged

elis_api_client: Add support for retrieving EngineFields (sync + async) #91

merged 1 commit into from
Jan 14, 2025

Conversation

mondrasovic
Copy link

Implement support for retrieving EngineFields (in both sync and async versions). See the documentation for details.

asgeirrr
asgeirrr requested changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@asgeirrr asgeirrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would definitely

  • add tests
  • try to remove the line-break changes introduced by ruff
  • change the commit to start with feat:, we're using automatic semantic releasing based on commit descriptions to release new version

🙏 Otherwise, LGTM.

rossum_api/elis_api_client.py Outdated Show resolved Hide resolved
@mondrasovic mondrasovic force-pushed the mo/retrieve-engine-fields branch 7 times, most recently from d9fddac to 00b86c0 Compare January 14, 2025 16:28
@mondrasovic mondrasovic force-pushed the mo/retrieve-engine-fields branch from 00b86c0 to c976954 Compare January 14, 2025 16:55
asgeirrr
asgeirrr approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@asgeirrr asgeirrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome first contribution to rossum-sdk, thanks 🎉

@asgeirrr asgeirrr merged commit ce66046 into rossumai:main Jan 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asgeirrr asgeirrr asgeirrr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mondrasovic @asgeirrr