This repository has been archived by the owner on Jan 14, 2023. It is now read-only.
Storing fields in MessageFields as indexed List instead of multiple Maps #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aps - speed and space optimization
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MessageFields contains 3 HashMaps which are created and populated for each message. That is both slow and memory hungry.
Very well observable when sending MarkerArray messages containing many Markers at high rate, especially on Android (slow and OOM).
This fix replaces HashMaps with ArrayList in MessageFields and moves the HashMaps logic to MessageContent.
Speed and memory improvements are more than noticable.