add test for set_parameters_atomically #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelarguedas
added
in review
|
Have you thought about adding a local test too? |
|
Yeah, I didnt see much benefit so focused on showing that the expected usage (remote) would stop segfaulting once ros2/rclcpp#494 is merged. If you think covering the async and local cases are requirement for getting this merged I can try revisiting it later this week. |
clalancette
approved these changes
Jun 12, 2018
|
it'd be good to have the rest of the tests, but I understand it's not the highest priority at the moment! |
Ticketed at #282 as I'm not sure I'll have time to address this this week, but I'll try to get around doing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rclcpp#494
leaving in progress until ci comes back green