Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Visualizing-ROS-2-Data-With-Foxglove-Studio.rst #4954

Open
wants to merge 2 commits into
base: humble
Choose a base branch
from

Conversation

rpl-harrison-parkes
Copy link

Removed unnecessary explicit mention of Google Chrome, other browsers work too.

Removed unnecessary explicit mention of specific browser name

Signed-off-by: Harry Parkes <[email protected]>
@clalancette
Copy link
Contributor

Removed unnecessary explicit mention of Google Chrome, other browsers work too.

We went through this when we updated this documentation in #4620, and the Foxglove devs explicitly said that only Google Chrome is supported. @banisadr has anything changed here?

Added message about official browser support

Signed-off-by: Harry Parkes <[email protected]>
@rpl-harrison-parkes
Copy link
Author

Removed unnecessary explicit mention of Google Chrome, other browsers work too.

We went through this when we updated this documentation in #4620, and the Foxglove devs explicitly said that only Google Chrome is supported. @banisadr has anything changed here?

Appologies, I was not aware of this. Maybe a different message could make this more clear.

@banisadr
Copy link
Contributor

I made a fairly extensive revision of this page in the rolling documentation, but realizing I didn't update the non-rolling doc sets. @clalancette what's the best practice? Should I make PRs for the other branches? The rewrite is relevant across the ROS 1 and 2 flavors.

@rpl-harrison-parkes, thanks for pointing this out. As you said, it could be clearer—the rolling docs include a note on why we recommend Chrom specifically, but also that you could use other browsers, though YMMV.

@clalancette
Copy link
Contributor

I made a fairly extensive revision of this page in the rolling documentation, but realizing I didn't update the non-rolling doc sets. @clalancette what's the best practice? Should I make PRs for the other branches? The rewrite is relevant across the ROS 1 and 2 flavors.

Yes, please open up PRs for both Jazzy and Humble. Thanks!

@clalancette clalancette added the more-information-needed Further information is required label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more-information-needed Further information is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants