add Extra Arguments for Component Manager. #4904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya Fujita <[email protected]>
|
@mjcarroll can you take a look? |
fujitatomoya
commented
Dec 14, 2024
|
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/12402722626/artifacts/2340456314. To view the resulting site:
|
kscottz
reviewed
Dec 16, 2024
Signed-off-by: Tomoya Fujita <[email protected]>
kscottz
approved these changes
Dec 18, 2024
clalancette
requested changes
Dec 18, 2024
Signed-off-by: Tomoya Fujita <[email protected]>
|
@clalancette all your comments are addressed in 8c0112b |
|
@clalancette friendly ping, another component related stuff. i can take care of the backport with a bit adjustment once this is merged. |
|
I will go ahead to merge this with approval and all comments are addressed. |
fujitatomoya
deleted the
fujitatomoya/add-component-manager-extra-args
branch
fujitatomoya
added
the
backport-all
mergify bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
* add Extra Arguments for Component Manager. Signed-off-by: Tomoya Fujita <[email protected]> * move the command line example before the table. Signed-off-by: Tomoya Fujita <[email protected]> * address review comments. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 1c8de6b)
mergify bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
* add Extra Arguments for Component Manager. Signed-off-by: Tomoya Fujita <[email protected]> * move the command line example before the table. Signed-off-by: Tomoya Fujita <[email protected]> * address review comments. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 1c8de6b)
fujitatomoya
added a commit
that referenced
this pull request
Jan 15, 2025
* add Extra Arguments for Component Manager. (#4904) * add Extra Arguments for Component Manager. Signed-off-by: Tomoya Fujita <[email protected]> * move the command line example before the table. Signed-off-by: Tomoya Fujita <[email protected]> * address review comments. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 1c8de6b) * drop unsupported properties from extra arguments. Signed-off-by: Tomoya.Fujita <[email protected]> --------- Signed-off-by: Tomoya.Fujita <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]>
fujitatomoya
added a commit
that referenced
this pull request
Jan 15, 2025
* add Extra Arguments for Component Manager. (#4904) * add Extra Arguments for Component Manager. Signed-off-by: Tomoya Fujita <[email protected]> * move the command line example before the table. Signed-off-by: Tomoya Fujita <[email protected]> * address review comments. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 1c8de6b) * drop unsupported properties from extra arguments. Signed-off-by: Tomoya.Fujita <[email protected]> --------- Signed-off-by: Tomoya.Fujita <[email protected]> Co-authored-by: Tomoya Fujita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up of ros2/rclcpp#2685