Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce RMW_EVENT_TYPE_MAX in rmw_event_type_t. #785

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from
Open

introduce RMW_EVENT_TYPE_MAX in rmw_event_type_t. #785

wants to merge 1 commit into from

Conversation

fujitatomoya
Copy link
Collaborator

depends on ros2/rmw#380

@fujitatomoya fujitatomoya mentioned this pull request Oct 11, 2024
Open
fujitatomoya
fujitatomoya commented Oct 11, 2024
View reviewed changes
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reference why we change this: ros2/rmw#380 (comment)

@fujitatomoya
Copy link
Collaborator Author

Pulls: ros2/rmw#380, ros2/rmw_connextdds#162, #785
Gist: https://gist.githubusercontent.com/fujitatomoya/287bc10787b6388b8c13bf6fdfa4d974/raw/ec909bd20c342c882a27450c57dc05ce62d209b5/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_connextdds_common rmw_fastrtps_shared_cpp
TEST args: --packages-above rmw rmw_connextdds_common rmw_fastrtps_shared_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14697

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya mentioned this pull request Oct 11, 2024
Open
MiguelCompany
MiguelCompany approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@fujitatomoya
Copy link
Collaborator Author

Pulls: ros2/rmw#380, #785, ros2/rmw_connextdds#162, ros2/rmw_cyclonedds#518
Gist: https://gist.githubusercontent.com/fujitatomoya/a5a27e64c97e3b687ed9c85018393aef/raw/398849da025367226392ce4eacd4f8114a09b768/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
TEST args: --packages-above rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14711

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya mentioned this pull request Oct 16, 2024
Open
@fujitatomoya fujitatomoya force-pushed the fujitatomoya/return-zero-structure branch from efdce01 to 3e9f274 Compare October 17, 2024 03:25
@fujitatomoya
Copy link
Collaborator Author

Pulls: ros2/rmw#380, #785, ros2/rmw_connextdds#162, ros2/rmw_cyclonedds#518
Gist: https://gist.githubusercontent.com/fujitatomoya/6abc026e02c2c115a589c04c79e23c39/raw/398849da025367226392ce4eacd4f8114a09b768/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
TEST args: --packages-above rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14714

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

Pulls: ros2/rmw#380, #785, ros2/rmw_connextdds#162, ros2/rmw_cyclonedds#518
Gist: https://gist.githubusercontent.com/fujitatomoya/82891bb189950fefcf68c0f191365af1/raw/398849da025367226392ce4eacd4f8114a09b768/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
TEST args: --packages-above rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14720

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

Pulls: ros2/rmw#380, #785, ros2/rmw_connextdds#162, ros2/rmw_cyclonedds#518
Gist: https://gist.githubusercontent.com/fujitatomoya/16961ebf1f4059173817c9730b42d685/raw/398849da025367226392ce4eacd4f8114a09b768/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
TEST args: --packages-above rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14722

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Oct 19, 2024 •
edited
Loading

Pulls: ros2/rmw#380, #785, ros2/rmw_connextdds#162, ros2/rmw_cyclonedds#518
Gist: https://gist.githubusercontent.com/fujitatomoya/065211cb8895027ee0a710a50b6a9851/raw/398849da025367226392ce4eacd4f8114a09b768/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
TEST args: --packages-above rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14726

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

@gbiggs gbiggs Awaiting requested review from gbiggs gbiggs is a code owner

@sloretz sloretz Awaiting requested review from sloretz sloretz is a code owner

Assignees

@clalancette clalancette

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fujitatomoya @MiguelCompany @clalancette