Revert ServicePubListener API break #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
clalancette
approved these changes
Oct 28, 2020
|
CI:
|
jacobperron
approved these changes
Oct 28, 2020
jacobperron
requested changes
Oct 28, 2020
rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/custom_service_info.hpp
Show resolved
Hide resolved
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
clalancette
approved these changes
Oct 29, 2020
jacobperron
approved these changes
Oct 29, 2020
|
@JLBuenoLopez-eProsima check MacOS CI failures! |
|
Nope ! Re-running CI:
|
hidmic
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#467 introduced an API break that it is not required for the workaround. This pull request reverts that break.
Signed-off-by: JLBuenoLopez-eProsima [email protected]