Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to 24.04 buildfarm #799

Merged
merged 13 commits into from
Jan 23, 2025
Merged

Conversation

claraberendsen
Copy link
Contributor

@claraberendsen claraberendsen commented Dec 20, 2024

Description

This PR contains the needed changes to ros2/ci that work in tandem with the new Jenkins controller on 24.04 and updated plugins.

Changes

  • Update of github credential key
  • Use of --cap-add NET-ADMIN instead of privileged due to a issue reported on https://github.com/osrf/chef-osrf/issues/296. Since this change is removing privileges from the containers and is an improvement on security posture this is implemented across the jobs.
  • Set of set -ex on entrypoint script to catch errors on prod.
  • Updates to xml jobs to match new plugin versions

@claraberendsen claraberendsen self-assigned this Jan 9, 2025
@nuclearsandwich nuclearsandwich force-pushed the claraberendsen/updates-for-24.04 branch from 2c13389 to 142f00d Compare January 21, 2025 03:45
@claraberendsen claraberendsen marked this pull request as ready for review January 21, 2025 15:38
@claraberendsen claraberendsen merged commit e4974e5 into master Jan 23, 2025
1 check passed
@nuclearsandwich nuclearsandwich deleted the claraberendsen/updates-for-24.04 branch January 23, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants