Using substitution args without ROS #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhaschke
reviewed
Mar 20, 2024
Co-authored-by: Robert Haschke <[email protected]>
|
Sure, I didn't notice. I committed the changes. |
rhaschke
reviewed
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I have been trying to use xacro without ROS, installing directly via pip, as was discussed in issue 329. However, the current solution still does not allow to use substitution args when it is possible.
Conditionally importing substitution_args at line 288 only allows to use xacro without ROS if no substitution args are used at all. This because ament_index_python fails to import.
Moving the import of ament_index_python in _eval_find() at line 140 would allow to use all substitution args except for find, which I believe is quite reasonable in a situation in which ros is not available.
I implemented this and it seems to work nice.