Move tf2::impl::toQuaternion to tf2_geometry_msgs #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspricke
force-pushed
the
fix_circ_dependency
branch
2 times, most recently
from
f2b6318
to
bebb683
Compare
|
@tfoote any thoughts here? |
Closes: ros#275 This breaks the cycle between tf2 and tf2_geometry_msgs. I didn't add deprecated attributes for functions having tf2_geometry_msgs in the method signature, as they would need to have the right header imported anyhow.
jspricke
force-pushed
the
fix_circ_dependency
branch
from
bebb683
to
15b77ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #275
This breaks the cycle between tf2 and tf2_geometry_msgs.
I didn't add deprecated attributes for functions having
tf2_geometry_msgs in the method signature, as they would need to have
the right header imported anyhow.