-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Modern CMake practices #245
Comments
RFRIEDM-Trimble
added a commit
to RFRIEDM-Trimble/image_common
that referenced
this issue
May 30, 2022
* Attempt fix for ros-perception#245 Signed-off-by: Ryan Friedman <[email protected]>
Hi, @RFRIEDM-Trimble -- the CMake versions are defined in REP2000, and would have to be updated there. Looks like the highest version supported by all recommended Galactic platforms is 3.12.2. For Humble it's 3.14.4. https://www.ros.org/reps/rep-2000.html |
Got it. I'll bump to 3.12.2 and implement the proposal. |
This was referenced Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a user of this library in gscam2, I'd like to consume the libraries in image_common with a modern cmake interface, but it's not supplied here.
Here's my proposal:
include_directories
withtarget_include_directories
ament_target_dependencies
withtarget_link_libraries
camera_calibration_parsers::camera_calibration_parsers
ament_export_include_directories
andament_export_libraries
calls as they are superfluousReferences:
The text was updated successfully, but these errors were encountered: