Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed missaligned fork me in Firefox #45

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed missaligned fork me in Firefox #45

wants to merge 2 commits into from

Conversation

Prathm-s
Copy link

Fixes #29.

Added class git-hub-icon to svg inside forkme div and added .git-hub-icon { right : 0 } in stylesheet.css

@Prathm-s
Update stylesheet.scss
211ed74 
Added git-hub-icon class and set right : 0
@Prathm-s
Update index.html
d97a09f 
Added git-hub-icon class to svg inside forkme
tfoote
tfoote requested changes May 23, 2023
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that it's missaligned in firefox. But it's there and even has a little wiggle when you mouse over

image

It seems like we should fix the alignment but not add a new graphic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"fork me" misaligned in Firefox
2 participants
@Prathm-s @tfoote