Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions for identifying changes to YAML files #4

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Jul 26, 2024

No description provided.

@cottsay cottsay self-assigned this Jul 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 62 lines in your changes missing coverage. Please review.

Project coverage is 62.79%. Comparing base (e6f3e7a) to head (6af1152).

Files Patch % Lines
rosdistro_reviewer/yaml_changes.py 0.00% 62 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (e6f3e7a) and HEAD (6af1152). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (e6f3e7a) HEAD (6af1152)
16 11
Additional details and impacted files
@@             Coverage Diff             @@
##             main       #4       +/-   ##
===========================================
- Coverage   98.18%   62.79%   -35.40%     
===========================================
  Files           3        4        +1     
  Lines         110      172       +62     
  Branches       28       50       +22     
===========================================
  Hits          108      108               
- Misses          0       62       +62     
  Partials        2        2               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from cottsay/yaml_lines to main August 2, 2024 14:56
Copy link

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was one general purpose function that I stumbled on out of context but nothing blocking.

rosdistro_reviewer/yaml_changes.py Show resolved Hide resolved
@cottsay cottsay merged commit e99eb31 into main Aug 2, 2024
18 checks passed
@cottsay cottsay deleted the cottsay/yaml_changes branch August 2, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants