Axial Symmetric Point Sampling #229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the given free-axis. Previously it forwarded to Cartesian pt's impl that used Euler angles and the result was just wrong for any free-axis that wasn't Z.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As has been discussed in the past, the Euler angle conventions used in Descartes default
CartesianPtleads to unexpected behavior sometimes.AxialSymmetricPt is supposed to be a short-hand for specifying rotation around only one of X, Y, or Z axes of a given, nominal frame. This PR changes this specific point type to "do the right thing" when it comes to point sampling.
Fixes for CartesianPt will be down the road.