Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove undocumented pix_fmt breaking new builds #343

Open
wants to merge 1 commit into
base: ros2
Choose a base branch
from

Conversation

Pleune
Copy link

@Pleune Pleune commented Aug 23, 2024

This no longer exists in ffmpeg trunk. I see that is exists in older versions, such as 2.7. However, even in those versions, it is not documented.

There are similarly named and now document formats such as AV_PIX_FMT_XV30 and AV_PIX_FMT_XV60, which should probably be supported instead, but I will not add these in this PR.

This solves include/usb_cam/formats/av_pixel_format_helper.hpp:747:32: error: ‘AV_PIX_FMT_XVMC’ was not declared in this scope; did you mean ‘AV_PIX_FMT_XV30’? in my build.

This no longer exists in ffmpeg trunk. I see that is exists in older
versions, such as 2.7. However, here it is not documented.

There are simmilarly named and now document formats such as AV_PIX_FMT_XV30
and AV_PIX_FMT_XV60, which should probably be supported instread, but I
will not add these in this commit.
@Pleune Pleune force-pushed the remove-undocumented-and-removed-pix-fmt branch from 4cc8cf3 to 1d1970b Compare August 23, 2024 14:17
@Pleune Pleune changed the title Remove undocumented and removed pix fmt Remove undocumented pix_fmt breaking new builds Aug 24, 2024
@flynneva flynneva self-requested a review August 26, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant