Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible implementation of #146 #167

Merged
merged 4 commits into from
Sep 9, 2023
Merged

Possible implementation of #146 #167

merged 4 commits into from
Sep 9, 2023

Conversation

chainsawriot
Copy link
Collaborator

No description provided.

@chainsawriot
Copy link
Collaborator Author

chainsawriot commented Sep 5, 2023

@pbrohan I tried to quickly implement this for #146 . The tests are just temp. disabled. Please have a look.

I was thinking about implementing an option (for backward compatibility with the one-month old 2.0). getOption("readODS.disablezerorow", FALSE). If options("readODS.disablezerorow") is TRUE, the same v2.0.0 behavior should be expected.

@chainsawriot
Copy link
Collaborator Author

The failing check for R 3.6 is due to the fact that

readr:::type_convert(data.frame(y = character()))

produces warnings. In modern R, it won't.

Can either suppress the warning or skip type_convert when nrow is 0.

@chainsawriot chainsawriot marked this pull request as ready for review September 9, 2023 13:23
@chainsawriot chainsawriot merged commit e0f5c09 into v2.1 Sep 9, 2023
@chainsawriot chainsawriot deleted the single branch September 9, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant