Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reopen #34 #39

Merged
merged 4 commits into from
Jun 25, 2021
Merged

Reopen #34 #39

merged 4 commits into from
Jun 25, 2021

Conversation

jmtaylor-fhcrc
Copy link
Contributor

Reopens PR #34 after it was reverted. PR #34 was reverted due to accidentally being merged with main before being reviewed or tested with CI.

Copy link
Contributor

@helenmiller16 helenmiller16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Why are you disabling the option to run tests against the test server?

@jmtaylor-fhcrc
Copy link
Contributor Author

Why are you disabling the option to run tests against the test server?

I have re-enabled the option with a comment in the helper file on how to enable staging server testing.

@jmtaylor-fhcrc jmtaylor-fhcrc merged commit 63bc7b3 into main Jun 25, 2021
@juyeongkim juyeongkim deleted the issue20 branch January 13, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants